[google-web-toolkit] [EMAIL PROTECTED] commented on branch /branches/1_6_clean_events. Details are at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events
General Comment: ListenerWrapper: http://code.google.com/p/google-web-toolkit/source/browse/branches/1_6_clean_events/user/src/com/google/gwt/user/client/ListenerWrapper.java?spec=issue3083&r=4020 Line-by-line comments: File: /branches/1_6_clean_events/user/src/com/google/gwt/user/client/ListenerWrapper.java (r4020) =============================================================================== Line 36: * @see com.google.gwt.user.L ------------------------------------------------------------------------------- Is this @see still correct? Line 40: abstract class ListenerWrapper<T> implements EventHandler { ------------------------------------------------------------------------------- Isn't this a ListenerAdapter since it translates listeners into handlers? I don't feel strongly either way. Also, I left a comment in HandlerManager asking if it's possible for these to keep references to their removers rather than keeping a listeners as that could allows us to get rid of HandlerManager.removeHandler. Respond to these comments at http://code.google.com/p/google-web-toolkit/source/branch?spec=issue3083&branch=%2Fbranches%2F1_6_clean_events -- You received this message because you starred this review, or because your project has directed all notifications to a mailing list that you subscribe to. You may adjust your review notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
