I uploaded a new patch. let me know what you think.
http://galgwt-reviews.appspot.com/203/diff/25/45 File visualization/src/com/google/gwt/visualization/client/CommonChartOptions.java (right): http://galgwt-reviews.appspot.com/203/diff/25/45#newcode34 Line 34: this.is3D = enable3D; actually, this should not be part of CommonChartOptions at all. Pie, Bar, and Column support this, but Area, Line, and Scatter do not. Good catch! http://galgwt-reviews.appspot.com/203/diff/25/45#newcode54 Line 54: setLegend(position.toString()); you're right. I moved it up to Common. http://galgwt-reviews.appspot.com/203/diff/25/41 File visualization/src/com/google/gwt/visualization/client/LegendPosition.java (right): http://galgwt-reviews.appspot.com/203/diff/25/41#newcode24 Line 24: public class LegendPosition { the class comment attempts to answer that question. is it unclear? http://galgwt-reviews.appspot.com/203/diff/25/37 File visualization/src/com/google/gwt/visualization/client/visualizations/ScatterChart.java (right): http://galgwt-reviews.appspot.com/203/diff/25/37#newcode39 Line 39: /** you're right, that's a doc error. it should be fixed soon. http://galgwt-reviews.appspot.com/203/diff/25/37#newcode57 Line 57: }-*/; that's in CommonOptions. http://galgwt-reviews.appspot.com/203 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
