[google-web-toolkit] kellegous commented on revision r4076.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4076
General Comment:
Going back through changes since last review. Some more comments on
GwtEvent.
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/shared/GwtEvent.java
(r4046)
===============================================================================
Line 19: * Root of all gwt events. All gwt events are considered dead and
should no
-------------------------------------------------------------------------------
s/gwt/GWT/
Line 26: public abstract class GwtEvent<H extends EventHandler> {
-------------------------------------------------------------------------------
I must admit that I'm still bothered by the fact that the ability to revive
events is part of the root class of events and therefore must be a part of
every event in the system. Yet, it's a system we don't even use in our
non-dom events. Plus, if we were to remove everything pertaining to
reviving events, the only thing left would be the source. When you do that,
GwtEvent as an interface seems pretty appealing.
Line 38: private int index;
-------------------------------------------------------------------------------
final
Line 59: private boolean dead;
-------------------------------------------------------------------------------
Did we ever resolve this:
"Do we need this? It seems like dead == true and source == null have
the same meaning."
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4076
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
