[google-web-toolkit] kellegous commented on revision r4076.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4076
General Comment:
HandlerManager updates.
Line-by-line comments:
File:
/branches/1_6_clean_events/user/src/com/google/gwt/event/shared/HandlerManager.java
(r4074)
===============================================================================
Line 136: H handler = getFlatHandler(base, i);
-------------------------------------------------------------------------------
Doesn't compile:
H handler = this.<H>getFlatHandler(base, i);
That fixes the compilation issue. Seems like an odd failure to me, could be
a JDT problem in our compiler.
Line 145: H handler = getHandler(handlers, i);
-------------------------------------------------------------------------------
Same compilation issue.
Line 167: throw new IndexOutOfBoundsException("index: " + index);
-------------------------------------------------------------------------------
When would an IndexOutOfBoundsException not be our bug here? I'm wondering
if this should just be an assert.
Line 187: return this[base + 1];
-------------------------------------------------------------------------------
this space is still here.
Line 250: for(var i = 0; i < count;i++){
-------------------------------------------------------------------------------
Indentation is still off here.
Line 292: javaScriptRegistry = JavaScriptObject.createObject().cast();
-------------------------------------------------------------------------------
Shouldn't this be JavaScriptObject.createArray().cast()?
Line 327: if (event.isLive() == false) {
-------------------------------------------------------------------------------
!event.isLive()
Line 463: @SuppressWarnings("unchecked")
-------------------------------------------------------------------------------
No uncheck operations in here now.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4076
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
