I checked about java.home, and as far as I can tell the patch is doing the right things.
I messed around with the threading logic, and did manage to come up with something I think is a little easier to reason about. It's not a huge advantage, but I get paranoid about concurrency bugs, so every little simplification helps. Instead of each task being a manager that itself reads from a queue of permutations to work on, each task is itself a permutation. There is a separate list of workers that are not currently in use. Advantages are: there is no more explicit use of synchronized, no more wait and notify calls, and no more need to use the interrupted flag on Java threads. Let's get this all merged together, now. Lex --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
PermutationWorkerFactory.java
Description: Binary data
diffFromBobs.patch
Description: Binary data
