Bob, you are awesome. I'm excited this went from design to implementation so quickly, since it solves a lot of headache in my current codebase. I only wish it made it into 1.6. :)
-Ray On Tue, Feb 10, 2009 at 4:31 PM, BobV <[email protected]> wrote: > > I have committed the SingleJsoImpl branch to trunk at r4689. > > Further comments from Lex's review: > - Fixed JSORestrictionsChecker to actually implement what's in the design > doc. > - Updated jsoRestrictions.html and changed JavaDoc in JSORC to point > to the design doc so that there's one canonical source of what > _should_ be implemented. > - Removed the allowJso() flag from JCastOperation and JInstanceOf in > favor of making CastNormalizer check against the list dual-impl > interfaces > - Renamed JTypeOracle.recomputeClinit() to > JTypeOracle.recomputeAfterOptimization() because it also causes > JsoSingleImpl data to be recomputed. This ensures that pruning > interacts favorably with the choice of methods used by CastNormalizer. > > -- > Bob Vawter > Google Web Toolkit Team > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
