On Thu, Mar 12, 2009 at 1:22 PM, Freeland Abbott <[email protected] > wrote:
> Sorry for the lag... > > 1. Why'd you specify branch & revision as transient? Not clearly > wrong, just seems unnecessary. > > To reflect the fact that their state is not persistent, they change and are clobbered during the course of 'execute'. They are basically only instance variables as a convenience. > > 1. You're changing the branch output from my "just the last term" spec > to "full branch path from repo root," right? That's surely more correctly > complete, but may make the tag a bit unwieldy. It's got some ripple > effects > in other tools we have, if we're changing spec. (I don't feel strongly, > though I'd originally take the last-term as "almost surely unique" and > mildly more usable.) > > I feel pretty strongly that we want the full tag from the svn root. Otherwise, the build contains insufficient data. You could imagine two different people building from change branches within their own username that happen to be named the same, e.g. changes/bobv/soyc vs. changes/spoon/soyc. I'd rather fix any downstream tooling. > > 1. Making svnversion optional doesn't distress me (and I assume git > can't offer it), but it does potentially allow people to misrepresent > builds > as being rNNN, when they're actually arbitrary local mods from NNN, perhaps > including split-version checkouts, but certainly including local edits. Do > we want the imprecision recorded somehow, if svnversion isn't present? > (This isn't entirely theoretical; both Ray and Joel have accidentally had > mixed-version workspaces, though only by branch-info.txt being off-base > w.r.t. the rest.) > > Lemme look into this.. I can almost certainly use some extra git commands to determine precisely whether or not there are local mods. The sweet thing about git (unlike svn) is you'll never get more than one svn revision.. it's just not possible. So the only possibilities are "releases/1...@4444" or "releases/1...@4444m". --Scott --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
