LGTM (though I'll admit to never touching git, so I'm going on faith for that downstream interface!)
On Thu, Mar 12, 2009 at 8:24 PM, Scott Blum <[email protected]> wrote: > Sweet! Here's patch #2 that adds git support, as well as a combined patch > for both. (I also included a slightly tweaked patch #1 from the previous > one I sent). > I'll go ahead and commit #1. > > --Scott, powered by git > > > On Thu, Mar 12, 2009 at 7:56 PM, Freeland Abbott < > [email protected]> wrote: > >> LGTM. Clearly there could be more tests (e.g. of ...NoErr), but I'm not >> going to hold back moving from "none" to "some" for that! >> >> >> On Thu, Mar 12, 2009 at 7:01 PM, Scott Blum <[email protected]> wrote: >> >>> Freeland, I decided to stage this in two sequential patches (and commits) >>> to make it easier to review and see the log. Here's patch #1, which merely >>> refactors the existing code to make it testable, and also makes the change >>> in how the branch specifier is computed. >>> The next patch, to actually add git support, should be small relative to >>> this. >>> >>> Thanks! >>> Scott >>> >>> >> > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
