Silly Rietveld didn't send my inline comments.
http://gwt-code-reviews.appspot.com/13804/diff/1/3 File user/src/com/google/gwt/user/client/rpc/RpcRequestBuilder.java (right): http://gwt-code-reviews.appspot.com/13804/diff/1/3#newcode29 Line 29: public class RpcRequestBuilder { Looks good, but you should add a unit test that confirms each override is actually called. http://gwt-code-reviews.appspot.com/13804/diff/1/5 File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java (right): http://gwt-code-reviews.appspot.com/13804/diff/1/5#newcode19 Line 19: * An interface implemented by client-side RPC proxy objects. Cast the object Can you fix this sentence while you're here? "Cast the object...should be cast..." http://gwt-code-reviews.appspot.com/13804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
