http://gwt-code-reviews.appspot.com/15803/diff/1/4 File user/src/com/google/gwt/dom/client/StyleInjector.java (right):
http://gwt-code-reviews.appspot.com/15803/diff/1/4#newcode42 Line 42: return injectStyleSheet(contents); You're ignoring element. How can you get away with that? Your public api implies promises that aren't being kept here--I'd assume that if I had <style> /* a */</style><style> /* b */</style><style> /* c */</style> and I called this with the b block as an argument, that the rules would be inserted before those in c block. This would be inserting it after c, right? You should extend the test to cover this case. http://gwt-code-reviews.appspot.com/15803/diff/1/4#newcode117 Line 117: assert element != null : "No element"; no comparable null check on the non-IE code (ditto in injectStyleSheetBefore). Those who don't run IE hosted mode will be hosed. http://gwt-code-reviews.appspot.com/15803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
