LGTM

Some nits, do with them what you will and commit this puppy.


http://gwt-code-reviews.appspot.com/15803/diff/4001/4004
File user/src/com/google/gwt/dom/client/StyleInjector.java (right):

http://gwt-code-reviews.appspot.com/15803/diff/4001/4004#newcode35
Line 35: "head").getItem(0));
line too long

http://gwt-code-reviews.appspot.com/15803/diff/4001/4004#newcode79
Line 79: private static final JsArrayInteger STYLE_ELEMENT_LENGTHS =
JavaScriptObject.createArray().cast();
two lines too long

http://gwt-code-reviews.appspot.com/15803/diff/4001/4004#newcode195
Line 195: * previously-created element and adding a new one.
Should mention in the doc on these methods returning StyleElement that
on IE they may include more than just the injected contents. Tempted to
suggest making them void return.

http://gwt-code-reviews.appspot.com/15803

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to