On Thu, Apr 16, 2009 at 5:27 PM, Lex Spoon <[email protected]> wrote:

> >> I wouldn't expect TypeExposureComputer to need to report any problems.
> >> Did you run any any cases where it should?  Barring an argument to the
> >
> >  Not directly, no, but it's needed for pass-through to e.g.
> > STOB.shouldConsiderFieldsForSerialization by way of
> > computeIndirectExposureCauses().
>
> In that case it seems better to pass in an empty problem report, as is
> done for similar methods that expect a logger.
>

Are we assured that the TIEC won't, in its wanderings back through STOB,
visit anything that hasn't already been touched?  (Bearing in mind that
"visitation" now implies "creating TIC" which implies "short circuiting
revisitation," so we only get one shot to collect problems uncovered....)

If we are, then yes, instead of passing through I can create and discard new
ProblemReports.

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to