See http://gwt-code-reviews.appspot.com/25803 for updated patch.
On 2009/04/21 16:49:12, rjrjr wrote: > http://gwt-code-reviews.appspot.com/25801/diff/1/3 > File user/src/com/google/gwt/event/shared/HandlerManager.java (right): > http://gwt-code-reviews.appspot.com/25801/diff/1/3#newcode101 > Line 101: } > Could be a little simpler--you don't really need an else case: > boolean result = false; > if (l != null) { > result = l.remove(handler); > ... > } > assert result... > http://gwt-code-reviews.appspot.com/25801/diff/1/2 > File user/test/com/google/gwt/event/shared/HandlerManagerTest.java (right): > http://gwt-code-reviews.appspot.com/25801/diff/1/2#newcode276 > Line 276: } > Should also have the non-isScript test that would have blown up with the old > code: > else { > reg.removeHandler(); > /* pass, we didn't hit an NPE */ > } http://gwt-code-reviews.appspot.com/25801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
