Reviewers: jlabanca, Description: Fixes issue 3586
Please review this at http://gwt-code-reviews.appspot.com/29801 Affected files: user/src/com/google/gwt/user/client/ui/UIObject.java user/test/com/google/gwt/user/client/ui/UIObjectTest.java Index: user/src/com/google/gwt/user/client/ui/UIObject.java =================================================================== --- user/src/com/google/gwt/user/client/ui/UIObject.java (revision 5255) +++ user/src/com/google/gwt/user/client/ui/UIObject.java (working copy) @@ -16,8 +16,8 @@ package com.google.gwt.user.client.ui; import com.google.gwt.core.client.GWT; +import com.google.gwt.dom.client.Element; import com.google.gwt.user.client.DOM; -import com.google.gwt.dom.client.Element; /** * The superclass for all user-interface objects. It simply wraps a DOM element, @@ -723,7 +723,7 @@ */ @Override public String toString() { - if (getElement() == null) { + if (element == null) { return "(null handle)"; } return DOM.toString(getElement()); Index: user/test/com/google/gwt/user/client/ui/UIObjectTest.java =================================================================== --- user/test/com/google/gwt/user/client/ui/UIObjectTest.java (revision 5255) +++ user/test/com/google/gwt/user/client/ui/UIObjectTest.java (working copy) @@ -15,6 +15,8 @@ */ package com.google.gwt.user.client.ui; +import com.google.gwt.dom.client.Document; +import com.google.gwt.dom.client.SpanElement; import com.google.gwt.junit.client.GWTTestCase; import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.Element; @@ -70,6 +72,14 @@ public String getModuleName() { return "com.google.gwt.user.DebugTest"; } + + public void testToString() { + UIObject u = new UIObject(){}; + assertEquals("(null handle)", u.toString()); + SpanElement span = Document.get().createSpanElement(); + u.setElement(span); + assertEquals(span.toString(), u.toString()); + } public void testAccidentalPrimary() { MyObject o = new MyObject(); --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
