Author: [email protected]
Date: Wed Apr 22 16:13:54 2009
New Revision: 5271
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/shell/rewrite/HostedModeClassRewriter.java
Log:
Add comment explaining why we skip stack map frames.
Modified:
changes/jat/ihm/dev/core/src/com/google/gwt/dev/shell/rewrite/HostedModeClassRewriter.java
==============================================================================
---
changes/jat/ihm/dev/core/src/com/google/gwt/dev/shell/rewrite/HostedModeClassRewriter.java
(original)
+++
changes/jat/ihm/dev/core/src/com/google/gwt/dev/shell/rewrite/HostedModeClassRewriter.java
Wed Apr 22 16:13:54 2009
@@ -219,6 +219,13 @@
v = new ForceClassVersion15(v);
}
+ /*
+ * We want to skip reading the stack map frames since we don't modify
them
+ * to reflect the changes made by our rewriters. Leaving them in can
+ * confuse ASM, javap, and potentially the jvm. Also, doing the work
at
+ * runtime to compute the proper stack maps is almost certainly going
to be
+ * slower than just letting the JVM's bytecode verifier do that itself.
+ */
new ClassReader(classBytes).accept(v, ClassReader.SKIP_FRAMES);
byte[] result = writer.toByteArray();
// System.err.println("Rewritten output for " + className);
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
