MenuBar - I'm fine with exposing the methods, but I think we would need to give them better names than moveUp() and moveDown(), as that has multiple ambiguous meetings. A name like moveSelectionUp/Down() would be more appropriate.
MenuItem - LGTM Thanks, John LaBanca [email protected] On Tue, Apr 28, 2009 at 11:40 PM, Freeland Abbott <[email protected]>wrote: > Joel (and John), > Take a look at the attached patch... it's all visibility changes > (moveUp/Down become public, setSelectionStyle protected for test access from > client-code packages), except for a bugfix in selectFirstItemIfNoneSelected > to ensure that there actually is a a "first item" to select. > > Thoughts? > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
