How's this?
Note there's a small semantic shift: previously, selectFirstItemIfNoneSelected
"assumed" the menu was non-empty; it no longer does so, and returns true ("none
was previously selected") in that case, while doing nothing. That, I think
correctly, makes moveSelectionDown/Up, moveToNext/PrevItem, and
onBrowserEvent robust for empty menus.On Wed, Apr 29, 2009 at 10:14 AM, John LaBanca <[email protected]> wrote: > MenuBar - I'm fine with exposing the methods, but I think we would need to > give them better names than moveUp() and moveDown(), as that has multiple > ambiguous meetings. A name like moveSelectionUp/Down() would be more > appropriate. > > MenuItem - LGTM > > Thanks, > John LaBanca > [email protected] > > > > On Tue, Apr 28, 2009 at 11:40 PM, Freeland Abbott <[email protected]>wrote: > >> Joel (and John), >> Take a look at the attached patch... it's all visibility changes >> (moveUp/Down become public, setSelectionStyle protected for test access from >> client-code packages), except for a bugfix in selectFirstItemIfNoneSelected >> to ensure that there actually is a a "first item" to select. >> >> Thoughts? >> >> > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
[email protected]
Description: Binary data
