Since we later use outFile.setLastModified(artifact.getLastModified()), thus ensuring equality, yeah, that <= is wrong....
On Fri, Jun 5, 2009 at 9:45 AM, Joel Webber <[email protected]> wrote: > Agreed, this comparison looks wrong, though it's not immediately obvious to > me how this affects hosted-mode startup (linking the compiled output, I > could see being affected). @bob, scott: Any thoughts on this? > > > On Fri, Jun 5, 2009 at 8:14 AM, Sanjiv Jivan <[email protected]>wrote: > >> >> Hi, >> Some of the users of SmartGWT have reported slow startup in hosted >> mode. A user narrowed down the problem to the following call in >> StandardLinkerContext. >> >> outFile.lastModified() <= artifact.getLastModified() >> >> When changed to outFile.lastModified() < artifact.getLastModified(), >> the startup is normal. >> >> http://code.google.com/p/google-web-toolkit/issues/detail?id=3700 >> >> Can you guys comment on whether this is a valid change? >> >> One other thing that I noticed was that when I moved the resources >> (skin images) from the "public" path of my main module (SmartGwt), to >> a secondary module (SmartGwtXXXSkin), and the user is required to >> inherit both these modules, the hosted mode startup slowed down a fair >> bit compared to when he inherited only one module that also had the >> skins resources. Does this ring a bell? If not, I'll try to dig a >> little deeper into this and provide more information. >> >> Thanks, >> Sanjiv >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
