here the comments I was referring to.

http://gwt-code-reviews.appspot.com/50806/diff/1/5
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
(right):

http://gwt-code-reviews.appspot.com/50806/diff/1/5#newcode42
Line 42: * that wrap them.
"they throw" -> "it throws"?

http://gwt-code-reviews.appspot.com/50806/diff/1/5#newcode147
Line 147: * do repeated lookups into the dependencies table to follow
the chain.
Is the motivation here that otherwise we would get too much SOYC output?

http://gwt-code-reviews.appspot.com/50806/diff/1/3
File tools/soyc-vis/src/com/google/gwt/soyc/GlobalInformation.java
(right):

http://gwt-code-reviews.appspot.com/50806/diff/1/3#newcode61
Line 61: "Leftovers code", "leftovers");
I would leave the "neither initial nor exclusive to any split point" in
there (unless I missed it and it shows up somewhere else).

http://gwt-code-reviews.appspot.com/50806

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to