Thanks, Kathrin!  I'll update it as you request.  One question is in
there about the wording for the leftover fragment; what do you think?


http://gwt-code-reviews.appspot.com/50806/diff/1/5
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
(right):

http://gwt-code-reviews.appspot.com/50806/diff/1/5#newcode42
Line 42: * that wrap them.
I'll reword it to parse better.

http://gwt-code-reviews.appspot.com/50806/diff/1/5#newcode147
Line 147: * do repeated lookups into the dependencies table to follow
the chain.
Yes, and more specifically, it takes a while to compute all that output.
  I admit I didn't carefully time whether it helps, but it should.

http://gwt-code-reviews.appspot.com/50806/diff/1/3
File tools/soyc-vis/src/com/google/gwt/soyc/GlobalInformation.java
(right):

http://gwt-code-reviews.appspot.com/50806/diff/1/3#newcode61
Line 61: "Leftovers code", "leftovers");
Good eye.  How about "Leftover code not in any other category"?

The reason I dropped it is because there is now a *third* category:
split points in the initial sequence.  It was getting hard to fit on a
single header line in the output HTML if all the exceptions are listed!

http://gwt-code-reviews.appspot.com/50806

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to