Implementation changes LGTM. The internals of the compiler really need more documentation so other developers have a chance in hell of getting the zen of the current implementation when implementing new features.
http://gwt-code-reviews.appspot.com/54802/diff/1/2 File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (right): http://gwt-code-reviews.appspot.com/54802/diff/1/2#newcode214 Line 214: private final Map<JClassType, Set<JInterfaceType>> implementsMap = new IdentityHashMap<JClassType, Set<JInterfaceType>>(); Document all of the internal map fields. I didn't use them in the original implementation because their meanings aren't obvious. What is the difference between couldBeImplementedMap and couldImplementMap? http://gwt-code-reviews.appspot.com/54802/diff/1/2#newcode736 Line 736: * Returns true if qType is an implemented interface of type, directly or What does this mean "an implemented interface"? Do you mean "Returns true if qType implements the interface represented by type, either directly or indirectly"? http://gwt-code-reviews.appspot.com/54802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
