http://gwt-code-reviews.appspot.com/54802/diff/1/2 File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (right):
http://gwt-code-reviews.appspot.com/54802/diff/1/2#newcode214 Line 214: private final Map<JClassType, Set<JInterfaceType>> implementsMap = new IdentityHashMap<JClassType, Set<JInterfaceType>>(); On 2009/07/21 23:52:40, bobv wrote: > Document all of the internal map fields. I didn't use them in the original > implementation because their meanings aren't obvious. What is the difference > between couldBeImplementedMap and couldImplementMap? Glad to see you followed the existing pattern and didn't document the fields you added. :P I can add doc in a separate commit. http://gwt-code-reviews.appspot.com/54802/diff/1/2#newcode736 Line 736: * Returns true if qType is an implemented interface of type, directly or On 2009/07/21 23:52:40, bobv wrote: > What does this mean "an implemented interface"? Do you mean "Returns true if > qType implements the interface represented by type, either directly or > indirectly"? I mean "Returns true if type implements the interface represented by qType, either directly or indirectly." Will fix in a follow-on. NOTE: this was existing doc, I just made the methods private. http://gwt-code-reviews.appspot.com/54802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
