Now that our build file will depend on emma_ant.jar, I think it makes sense to extract it out. Since we already have an emma directory, I suggest we keep using it to avoid confusion. Any objections?
Thanks, John LaBanca [email protected] On Thu, Jul 23, 2009 at 3:21 PM, Amit Manjhi <[email protected]> wrote: > emma.jar includes our modifications to emma. That is why redist was chosen > instead of lib. > The version is included in the name of zip file: emma-2.0.5312-src.zip When > the zip file is expanded, it just includes 'emma.jar' with no version > number. So, it made sense to make emma with our patch available under the > same name. > > On Thu, Jul 23, 2009 at 11:53 AM, Scott Blum <[email protected]> wrote: > >> Also, don't we need a version on emma_ant.jar? There should have been one >> put on emma.jar, but it looks like an oversight. >> >> >> On Thu, Jul 23, 2009 at 2:51 PM, Scott Blum <[email protected]> wrote: >> >>> Why does emma live in redist/ instead of /lib anyway? >>> >>> >>> On Thu, Jul 23, 2009 at 2:47 PM, <[email protected]> wrote: >>> >>>> >>>> Reviewers: bruce, >>>> >>>> Description: >>>> This patch adds the emma_ant jar to our tools directory so the GWT build >>>> file can use it to generate code coverage data. We already include >>>> emma.jar. >>>> >>>> A subsequent patch to trunk will update the build files to add code >>>> coverage stats. >>>> >>>> Please review this at http://gwt-code-reviews.appspot.com/51812 >>>> >>>> Affected files: >>>> redist/emma/README.txt >>>> redist/emma/emma_ant.jar >>>> >>>> >>>> Index: redist/emma/README.txt >>>> =================================================================== >>>> --- redist/emma/README.txt (revision 5777) >>>> +++ redist/emma/README.txt (working copy) >>>> @@ -9,6 +9,9 @@ >>>> >>>> emma.jar: the jar file produced by the patched emma. >>>> >>>> +emma_ant.jar: the jar file containing custom EMMA ant tasks that can be >>>> +downloaded from sourceforge.net. >>>> + >>>> com.mountainminds.eclemma.core_1.3.2.jar : eclemma jar containing the >>>> updated >>>> emma.jar >>>> >>>> Index: redist/emma/emma_ant.jar >>>> =================================================================== >>>> Cannot display: file marked as a binary type. >>>> svn:mime-type = application/octet-stream >>>> >>>> Property changes on: redist/emma/emma_ant.jar >>>> ___________________________________________________________________ >>>> Name: svn:mime-type >>>> + application/octet-stream >>>> >>>> >>>> >>>> >>>> >>>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
