Reviewers: bobv, Description: 1. Change StackTraceElement#getFileName() to return null instead of "Unknown Source" to. See Javadoc which indicates null should be returned when filename is not available http://java.sun.com/j2se/1.4.2/docs/api/java/lang/StackTraceElement.html#getFileName()
2. Change StackTraceElement#toString so that the filename:lineNumber pair is not included when the filename is not available, so that "Unknown.foo(Unknown Source:0)" becomes "Unknown.foo()" Please review this at http://gwt-code-reviews.appspot.com/54815 Affected files: user/src/com/google/gwt/core/client/impl/StackTraceCreator.java user/super/com/google/gwt/emul/java/lang/StackTraceElement.java Index: user/src/com/google/gwt/core/client/impl/StackTraceCreator.java =================================================================== --- user/src/com/google/gwt/core/client/impl/StackTraceCreator.java (revision 5861) +++ user/src/com/google/gwt/core/client/impl/StackTraceCreator.java (working copy) @@ -67,8 +67,7 @@ StackTraceElement[] stackTrace = new StackTraceElement[stack.length()]; for (int i = 0, j = stackTrace.length; i < j; i++) { - stackTrace[i] = new StackTraceElement("Unknown", stack.get(i), - "Unknown source", 0); + stackTrace[i] = new StackTraceElement("Unknown", stack.get(i), null, 0); } e.setStackTrace(stackTrace); } @@ -77,8 +76,7 @@ JsArrayString stack = StackTraceCreator.createStackTrace(); StackTraceElement[] stackTrace = new StackTraceElement[stack.length()]; for (int i = 0, j = stackTrace.length; i < j; i++) { - stackTrace[i] = new StackTraceElement("Unknown", stack.get(i), - "Unknown source", 0); + stackTrace[i] = new StackTraceElement("Unknown", stack.get(i), null, 0); } t.setStackTrace(stackTrace); } Index: user/super/com/google/gwt/emul/java/lang/StackTraceElement.java =================================================================== --- user/super/com/google/gwt/emul/java/lang/StackTraceElement.java (revision 5861) +++ user/super/com/google/gwt/emul/java/lang/StackTraceElement.java (working copy) @@ -60,7 +60,7 @@ } public String toString() { - return className + "." + methodName + "(" + fileName + ":" + lineNumber - + ")"; + return className + "." + methodName + "(" + + (fileName != null ? fileName + ":" + lineNumber : "") + ")"; } } --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
