The next patch set will also contain the following changes: - HasLayout has become RequiresLayout and ProvidesLayout (just a tag interface). The original design conflated the concepts of "This method (layout) needs to be called whenever you update any of my childrens' layers" and "This widget needs to be informed whenever its size changes".
- For the above reason, it is now necessary to call layout() explicitly when childrens' layers are updated, even on RootLayoutPanel. - Layer.userData (now userObject) has been made invariant. http://gwt-code-reviews.appspot.com/51830/diff/1/2 File layout/Layout.gwt.xml (right): http://gwt-code-reviews.appspot.com/51830/diff/1/2#newcode17 Line 17: <inherits name="com.google.gwt.user.UserAgent"/> On 2009/08/03 20:14:01, jlabanca wrote: > Fix indent spacing Done. http://gwt-code-reviews.appspot.com/51830/diff/1/2#newcode19 Line 19: <inherits name="com.google.gwt.animation.Animation"/> On 2009/08/03 20:14:01, jlabanca wrote: > Fix indent spacing Done. http://gwt-code-reviews.appspot.com/51830/diff/1/5 File layout/client/Layout.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode68 Line 68: * <code> On 2009/08/03 20:14:01, jlabanca wrote: > This code should be moved to the examples directory. Done. http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode102 Line 102: * warning. Use at your own risk. On 2009/08/03 20:14:01, jlabanca wrote: > Do we need a TODO to remove this when we release? Or are we going to change the > layout after we release? I've got a personal TODO to come back and clean all these up when we release. http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode154 Line 154: Object userData; On 2009/08/03 20:14:01, jlabanca wrote: > Should this be a parameterized type? Not really. It's up to the user to decide what they need to put there, and it could be heterogeneous. And we'd have to put the type parameter on the Layout class, which would be kind of weird and hard to fathom, I think. http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode177 Line 177: * This is the element that sits between the parent and child elements. It On 2009/08/03 20:14:01, jlabanca wrote: > typo - "It is normally", not "It normally" Done. http://gwt-code-reviews.appspot.com/51830/diff/1/3 File layout/client/LayoutImpl.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/3#newcode2 Line 2: * Copyright 2008 Google Inc. On 2009/08/03 20:14:01, jlabanca wrote: > 2009 Done. http://gwt-code-reviews.appspot.com/51830/diff/1/3#newcode112 Line 112: return fixedRuler.getOffsetWidth() * 2.54; Whoops, * is a typo. Should be /. Fixed by changing all operators to / for clarity. http://gwt-code-reviews.appspot.com/51830/diff/1/3#newcode116 Line 116: return fixedRuler.getOffsetWidth() / 2.36; On 2009/08/04 15:43:56, bobv wrote: > Aren't these numbers subject to change based on display resolution? Ha, nope! The shared fixedRuler element is precisely 1 in in size. All of these other measurements can be derived from an "inch" with a known ratio. I picked inch because it's the largest available unit, and thus the least susceptible to aliasing (when converted to integral pixels). http://gwt-code-reviews.appspot.com/51830/diff/1/4 File layout/client/LayoutImplIE6.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/4#newcode2 Line 2: * Copyright 2008 Google Inc. On 2009/08/03 20:14:01, jlabanca wrote: > 2009 Done. http://gwt-code-reviews.appspot.com/51830/diff/1/11 File user/client/ui/LayoutPanel.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/11#newcode41 Line 41: * // Attach two child widgets, laying them out horizontally, splitting at 50%. On 2009/08/03 20:14:01, jlabanca wrote: > This code should be moved to the examples directory. Done. http://gwt-code-reviews.appspot.com/51830/diff/1/11#newcode142 Line 142: assert child.getParent() == this : "TODO"; On 2009/08/03 20:14:01, jlabanca wrote: > You should put a message here Done. http://gwt-code-reviews.appspot.com/51830/diff/1/12 File user/client/ui/RootLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/12#newcode48 Line 48: * // Attaches a pair of widgets to the RootLayoutPanel On 2009/08/03 20:14:01, jlabanca wrote: > Move to examples directory Done. http://gwt-code-reviews.appspot.com/51830 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
