Since this was committed TBR last night, I've added all the changes discussed here to http://gwt-code-reviews.appspot.com/55804
http://gwt-code-reviews.appspot.com/51830/diff/2003/2004 File user/javadoc/com/google/gwt/examples/LayoutPanelExample.java (right): http://gwt-code-reviews.appspot.com/51830/diff/2003/2004#newcode32 Line 32: Widget childOne = new HTML(), childTwo = new HTML(); On 2009/08/04 23:34:58, jlabanca wrote: > You should add some text to these HTML widgets so that if somebody uses the > example they will actually see childOne and childTwo. Done. http://gwt-code-reviews.appspot.com/51830/diff/2003/2010 File user/src/com/google/gwt/layout/client/Layout.java (right): http://gwt-code-reviews.appspot.com/51830/diff/2003/2010#newcode302 Line 302: public void animate(int duration) { On 2009/08/04 23:34:58, jlabanca wrote: > Didn't we agree that this would become layout(int duration)? I see that we now > have LayoutPanel#layout(int), but why not here? Whoops. I changed these in the widgets, but not in the Layout class. Done. http://gwt-code-reviews.appspot.com/51830/diff/2003/2010#newcode313 Line 313: public void animate(int duration, final AnimationCallback callback) { On 2009/08/04 23:34:58, jlabanca wrote: > And this would be layout(int duration, final AnimationCallback callback)? Done. http://gwt-code-reviews.appspot.com/51830/diff/2003/2014 File user/src/com/google/gwt/user/client/ui/ProvidesLayout.java (right): http://gwt-code-reviews.appspot.com/51830/diff/2003/2014#newcode29 Line 29: * public void onLayout() { On 2009/08/04 23:34:58, jlabanca wrote: > Can we move this to a static helper method in this interface to avoid code > duplication? It could take an Iterator<?> and look for instances of > RequiresLayout. That would be nice, wouldn't it? Unfortunately, Java, in its infinite wisdom (ha!), doesn't allow static methods on interfaces. I thought about putting it on LayoutPanel, or something like that, but it just didn't seem right. Other ideas welcome. http://gwt-code-reviews.appspot.com/51830/diff/2003/2006 File user/test/com/google/gwt/layout/client/LayoutTest.java (right): http://gwt-code-reviews.appspot.com/51830/diff/2003/2006#newcode57 Line 57: return "com.google.gwt.layout.Layout"; On 2009/08/04 23:34:58, jlabanca wrote: > Should be com.google.gwt.layout.LayoutTest Done. http://gwt-code-reviews.appspot.com/51830 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
