LGTM, based primarily on the fact that I know it works already, and with the knowledge that there are some tasks left to be completed (like the parser API).
I also assume that at some point we'll need to move the sample code out into a proper sample, and that we'll want to come back and change our existing samples to use UiBinder as well. http://gwt-code-reviews.appspot.com/51831/diff/1/2 File eclipse/user/.classpath (right): http://gwt-code-reviews.appspot.com/51831/diff/1/2#newcode19 Line 19: <classpathentry kind="var" path="GWT_TOOLS/lib/easymock/easymockclassextension.jar" sourcepath="/GWT_TOOLS/lib/easymock/easymockclassextension-src.zip"/> I'll assume that all these libraries are necessary, and that you've checked up on the licenses and made sure they're in the /tools repo. http://gwt-code-reviews.appspot.com/51831/diff/1/6 File user/src/com/google/gwt/uibinder/client/UiBinder.java (right): http://gwt-code-reviews.appspot.com/51831/diff/1/6#newcode36 Line 36: There was talk at one point of re-unifying these methods. If that's still in the cards, should we make a note to that effect as a warning? http://gwt-code-reviews.appspot.com/51831/diff/1/17 File user/src/com/google/gwt/uibinder/parsers/BooleanAttributeParser.java (right): http://gwt-code-reviews.appspot.com/51831/diff/1/17#newcode26 Line 26: // TODO(jgw): check validity. Hey, that looks like my mistake :) http://gwt-code-reviews.appspot.com/51831 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
