Thanks for the review.
http://gwt-code-reviews.appspot.com/51835/diff/3001/3006 File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (right): http://gwt-code-reviews.appspot.com/51835/diff/3001/3006#newcode23 Line 23: $legacyHosted = true; On 2009/08/06 19:17:50, amitmanjhi wrote: > Can we get rid of all code related to legacyHosted? Not yet, since people are still using it. When SWT is removed, this would be removed at the same time. http://gwt-code-reviews.appspot.com/51835/diff/3001/3006#newcode205 Line 205: } On 2009/08/06 19:17:50, amitmanjhi wrote: > Can make this clearer using ASCII_EXCLAMATION = 33 and ASCII_TILDA = 127. The > comment is then redundant. Ok. http://gwt-code-reviews.appspot.com/51835/diff/3001/3006#newcode238 Line 238: loadIframe("http://code.google.com/p/google-web-toolkit/wiki/TroubleshootingOOPHM";); On 2009/08/06 19:17:50, amitmanjhi wrote: > Does this wiki not exist yet? I could not find it. No. I will create at least a template before committing. http://gwt-code-reviews.appspot.com/51835/diff/3001/3008 File dev/core/src/com/google/gwt/dev/SwtHostedModeBase.java (right): http://gwt-code-reviews.appspot.com/51835/diff/3001/3008#newcode80 Line 80: String remoteEndpoint) throws UnableToCompleteException { On 2009/08/06 19:17:50, amitmanjhi wrote: > a more descriptive name than "string"? Missing javadoc on a public method. If > this class will be removed in 2.0, I suppose you can leave it as such. The auto-refactor of the implementing class did this, and I have already fixed it locally. In fact, it is url, sessionKey rather than sessionKey, string. http://gwt-code-reviews.appspot.com/51835/diff/3001/3003 File dev/oophm/src/com/google/gwt/dev/shell/BrowserChannel.java (right): http://gwt-code-reviews.appspot.com/51835/diff/3001/3003#newcode621 Line 621: } On 2009/08/06 19:17:50, amitmanjhi wrote: > Use enhanced-for loop? How would the enhanced for work here? I am assigning to the array elements. http://gwt-code-reviews.appspot.com/51835/diff/3001/3003#newcode643 Line 643: for (int i = 0; i < n; ++i) { On 2009/08/06 19:17:50, amitmanjhi wrote: > Use enhanced-for loop? Ok. http://gwt-code-reviews.appspot.com/51835/diff/3001/3003#newcode662 Line 662: } On 2009/08/06 19:17:50, amitmanjhi wrote: > Use enhanced-for loop? Again, doesn't work assigning to the array. http://gwt-code-reviews.appspot.com/51835 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
