@Bob, are you interested in reviewing these changes or should I just go with Amit's review?
While making changes from Amit's review, I noticed a bug which slipped past and decided I needed to find a way to test the wire protocol code. In the process, I found a couple more bugs in unused code (ie, receive of a message sent only from the server), but soon it won't be unused since the HTMLUnit hosted-mode client will need it. I also split Invoke into two separate messages (still using the same message tag on the wire) to match the asymmetric nature of the invoke messages (again, something which will be needed by the HTMLUnit client). http://gwt-code-reviews.appspot.com/51835/diff/3001/3003 File dev/oophm/src/com/google/gwt/dev/shell/BrowserChannel.java (right): http://gwt-code-reviews.appspot.com/51835/diff/3001/3003#newcode577 Line 577: * Reports the selected protocol version. Sorted. http://gwt-code-reviews.appspot.com/51835/diff/3001/3003#newcode696 Line 696: protected static class Connected extends Message { Unused cruft that was an early version of ProtocolVersion. http://gwt-code-reviews.appspot.com/51835/diff/4011/4014#newcode645 Line 645: } Was a bug, but since the browser plugins dont' currently do anything but log the fatal error it wasn't noticed. http://gwt-code-reviews.appspot.com/51835/diff/4011/4014#newcode709 Line 709: stream.readFully(plugin); Split this into different messages for each direction. Not only does this allow testing of the Java code, but it will be needed for the hosted mode HTMLUnit client as well. http://gwt-code-reviews.appspot.com/51835/diff/4011/4014#newcode891 Line 891: This was a bug before, but since we never receive the LoadJsni message on the server we never hit this code. http://gwt-code-reviews.appspot.com/51835/diff/4011/4014#newcode1072 Line 1072: * module (original v1 version). Another bug in unused code. http://gwt-code-reviews.appspot.com/51835 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
