Just nits. BTW: while you're in here, can you remove the 'normalize' call from Maps(112)? It's not necessary because if the incoming map has more than 1 entry, the result map will certainly have more than 1 and already be the right type.
http://gwt-code-reviews.appspot.com/56806/diff/1/2 File dev/core/src/com/google/gwt/dev/util/collect/Sets.java (right): http://gwt-code-reviews.appspot.com/56806/diff/1/2#newcode56 Line 56: if (toAdd.isEmpty()) { If you switch on the size here, you can see a slight benefit when toAdd.size() == 1. See Maps.putAll(). http://gwt-code-reviews.appspot.com/56806/diff/1/2#newcode60 Line 60: } else if (set.containsAll(toAdd)) { Given that this condition will almost never be true, it's not worth the execution time. http://gwt-code-reviews.appspot.com/56806 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
