http://gwt-code-reviews.appspot.com/56806/diff/1/2
File dev/core/src/com/google/gwt/dev/util/collect/Sets.java (right):

http://gwt-code-reviews.appspot.com/56806/diff/1/2#newcode76
Line 76: Set<T> result = new HashSet<T>(toAdd);
Actually, you can't do this, this is wrong.  You have to initialize with
the element already in the set, then add the incoming entries.
Otherwise, you get wrong behavior when dealing with equal objects with
different identity.  See Maps.putAll().

http://gwt-code-reviews.appspot.com/56806

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to