LGTM. One comment typo, one question about a possible extra test.
http://gwt-code-reviews.appspot.com/64812/diff/1/5 File user/src/com/google/gwt/uibinder/rebind/model/ImplicitCssResource.java (right): http://gwt-code-reviews.appspot.com/64812/diff/1/5#newcode67 Line 67: * file rather than look load a resource. Sounds just great. "rather than look load" --> "rather than load" http://gwt-code-reviews.appspot.com/64812/diff/1/5#newcode138 Line 138: * this package I don't know what else that utility does, but if nothing else loading from ResourceOracle has the advantage of centralizing the choice of class loader. http://gwt-code-reviews.appspot.com/64812/diff/1/9 File user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java (right): http://gwt-code-reviews.appspot.com/64812/diff/1/9#newcode281 Line 281: widgetUi.totallyPrivateStyleSpan.getClassName().length() > 0); How hard would it be to test that the style contents are sane? http://gwt-code-reviews.appspot.com/64812 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
