I think the ones in user/test are fine, but may I offer a note of caution to the one in user/src? Depending on the settings, some compilers will emit a warning if you try to suppress a warning that they don't understand, strangely enough. Non-GEP users might therefore get a warning about that on RpcService. Maybe the plugin should ignore that one, or many in general ones that don't have methods?
On Thu, Sep 17, 2009 at 2:09 PM, <[email protected]> wrote: > > Reviewers: Ray Ryan, > > Description: > Description: > ============ > The Google Eclipse Plugin generates some error messages in gwt-user > because we have some unmatched RemoveServices, which are used in tests. > > Fix: > ==== > Add @SuppressWarnings to each instance of this. Also add the gwtNature > to the user project file. I'll add the gwtNature to the samples in a > separate patch. > > Testing: > ======== > All errors are gone in Eclipse. > > Please review this at http://gwt-code-reviews.appspot.com/67802 > > Affected files: > eclipse/user/.project > user/src/com/google/gwt/rpc/client/RpcService.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java > > > user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java > user/test/com/google/gwt/user/server/rpc/RPCTest.java > > > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
