I actually did ignore it specifically, but I took your suggestion to not do that and simply rely on the annotation. We can treat RpcService specially.
On Thu, Sep 17, 2009 at 2:23 PM, Ray Ryan <[email protected]> wrote: > Miguel, are you and John in touch on this? I thought you were going to > special case RpcService itself so that we wouldn't need a suppress there. > > > On Thu, Sep 17, 2009 at 11:09 AM, <[email protected]> wrote: > >> Reviewers: Ray Ryan, >> >> Description: >> Description: >> ============ >> The Google Eclipse Plugin generates some error messages in gwt-user >> because we have some unmatched RemoveServices, which are used in tests. >> >> Fix: >> ==== >> Add @SuppressWarnings to each instance of this. Also add the gwtNature >> to the user project file. I'll add the gwtNature to the samples in a >> separate patch. >> >> Testing: >> ======== >> All errors are gone in Eclipse. >> >> Please review this at http://gwt-code-reviews.appspot.com/67802 >> >> Affected files: >> eclipse/user/.project >> user/src/com/google/gwt/rpc/client/RpcService.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/AbstractSerializableTypes.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ManualSerialization.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/MissingGwtTypeArgs.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/NoSerializableTypes.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectArrayInMethodSignature.java >> >> >> user/test/com/google/gwt/user/rebind/rpc/testcases/client/ObjectInMethodSignature.java >> user/test/com/google/gwt/user/server/rpc/RPCTest.java >> >> >> > -- Miguel --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
