LGTM assuming you have tested it on all platforms, with minor nits.
http://gwt-code-reviews.appspot.com/68806/diff/1/6 File dev/core/src/com/google/gwt/dev/SwtHostedModeBase.java (right): http://gwt-code-reviews.appspot.com/68806/diff/1/6#newcode88 Line 88: System.err.println(" Use a 32-bit capable Java runtime and add the -d32 flag if needed."); In some cases, the best way to do this will be to point JAVA_HOME at a different JVM install. Maybe this message should be more generic or should mention that option. http://gwt-code-reviews.appspot.com/68806/diff/1/6#newcode91 Line 91: } I don't think -1 is portable across all platforms -- on Unix-based systems, wait() returns an 8-bit value so this gets mapped to 255. I suggest 1 instead. http://gwt-code-reviews.appspot.com/68806 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
