LGTM, but I think you should avoid performing any tests on DataResource.getURL() that make assumptions about what kind of resource it is.
http://gwt-code-reviews.appspot.com/78808/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/BundleWriter.java (right): http://gwt-code-reviews.appspot.com/78808/diff/1/2#newcode90 Line 90: Should be zero-length. http://gwt-code-reviews.appspot.com/78808/diff/1/3 File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java (right): http://gwt-code-reviews.appspot.com/78808/diff/1/3#newcode233 Line 233: if ("with".equals(localName)) { Break out into enum in a future revision? http://gwt-code-reviews.appspot.com/78808/diff/1/4 File user/src/com/google/gwt/uibinder/rebind/model/ImplicitClientBundle.java (right): http://gwt-code-reviews.appspot.com/78808/diff/1/4#newcode120 Line 120: Trailing spaces. http://gwt-code-reviews.appspot.com/78808/diff/1/11 File user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java (right): http://gwt-code-reviews.appspot.com/78808/diff/1/11#newcode361 Line 361: public void testDataResource() { This test isn't right. On IE6 in https, we can't use mhtml and we might have to pull mhtml support for IE7+Vista if the spriting issues can't be solved. http://gwt-code-reviews.appspot.com/78808 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
