LGTM

http://gwt-code-reviews.appspot.com/78808/diff/24/1006
File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
(right):

http://gwt-code-reviews.appspot.com/78808/diff/24/1006#newcode71
Line 71: with {
Are the ui:foo tags case-sensitive?  It seems weird to have enum values
that aren't ALLCAPS.  You could wash the value passed to Enum.valueOf()
through String.toUpperCase() to normalize it.

Either way, please sort the values, since their ordinal values probably
aren't relevant.

http://gwt-code-reviews.appspot.com/78808

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to