LGTM, modulo one change I'd like to make in LayoutImplIE6.
http://gwt-code-reviews.appspot.com/77813/diff/52/53 File user/src/com/google/gwt/http/client/Request.java (right): http://gwt-code-reviews.appspot.com/77813/diff/52/53#newcode266 Line 266: fireOnResponseReceivedImpl(callback); It is safe to not use $entry() here because it's being handled by XMLHttpRequest, right? http://gwt-code-reviews.appspot.com/77813/diff/52/55 File user/src/com/google/gwt/layout/client/LayoutImplIE6.java (right): http://gwt-code-reviews.appspot.com/77813/diff/52/55#newcode248 Line 248: parent.onresize = $entry(function() { Let's not use $entry() in these two cases. There is no chance of user code being called from this callback, and I don't want to allow the possibility of anything getting in the way of handling resize events here. http://gwt-code-reviews.appspot.com/77813/diff/52/57 File user/src/com/google/gwt/user/client/DOM.java (right): http://gwt-code-reviews.appspot.com/77813/diff/52/57#newcode1263 Line 1263: dispatchEventImpl(evt, elem, listener); $entry() will have already been called by DOMImpl*, right? http://gwt-code-reviews.appspot.com/77813 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
