Patch updated.

http://gwt-code-reviews.appspot.com/77813/diff/52/53
File user/src/com/google/gwt/http/client/Request.java (right):

http://gwt-code-reviews.appspot.com/77813/diff/52/53#newcode266
Line 266: fireOnResponseReceivedImpl(callback);
On 2009/10/13 15:47:14, jgw wrote:
> It is safe to not use $entry() here because it's being handled by
> XMLHttpRequest, right?

Yes, this Request class is a wrapped around the xhr package.

http://gwt-code-reviews.appspot.com/77813/diff/52/55
File user/src/com/google/gwt/layout/client/LayoutImplIE6.java (right):

http://gwt-code-reviews.appspot.com/77813/diff/52/55#newcode248
Line 248: parent.onresize = $entry(function() {
Updated JavaDoc to indicate that $entry is intentionally skipped.

http://gwt-code-reviews.appspot.com/77813/diff/52/57
File user/src/com/google/gwt/user/client/DOM.java (right):

http://gwt-code-reviews.appspot.com/77813/diff/52/57#newcode1263
Line 1263: dispatchEventImpl(evt, elem, listener);
On 2009/10/13 15:47:14, jgw wrote:
> $entry() will have already been called by DOMImpl*, right?

Yes.

http://gwt-code-reviews.appspot.com/77813

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to