Still LGTM, modulo the clarification on return values from event handlers.
http://gwt-code-reviews.appspot.com/77810/diff/1007/30 File user/src/com/google/gwt/core/client/impl/Impl.java (right): http://gwt-code-reviews.appspot.com/77810/diff/1007/30#newcode166 Line 166: // What is the correct return value here or should we re-throw? On 2009/10/12 20:42:07, scottb wrote: > Shouldn't this be a void method anyway? (and so on up the stack) I would argue the same thing, given that it's silly to return anything from event handlers in general (DOM events allow a boolean return value, but it's just a shortcut for preventDefault()). Except that there's exactly one case where the return value is necessary and vital: window.onbeforeunload(). Its return value must be either a string or undefined, and returning a string causes the browser to display the "are you sure you want to leave this page" message. So we have no choice but to forward the return value. In this case, 'undefined' is the appropriate response if an exception is thrown, and I think it's safe to say that we should always return undefined if the exception is caught, and point out that this behavior is possible (preferably with a suggestion to avoid return values in event handlers, because they're normally stupid). http://gwt-code-reviews.appspot.com/77810 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
