http://gwt-code-reviews.appspot.com/77810/diff/34/1016 File user/src/com/google/gwt/core/client/impl/Impl.java (right):
http://gwt-code-reviews.appspot.com/77810/diff/34/1016#newcode54 Line 54: public static native JavaScriptObject entry(JavaScriptObject jsFunction) /*-{ I think this should be a public API on the GWT class, and referenced via JSNI rather than $entry; but I'm willing to defer to jgw. http://gwt-code-reviews.appspot.com/77810/diff/34/1016#newcode148 Line 148: _ = jsFunction.apply(thisObj, arguments); What's the motivation for this change? http://gwt-code-reviews.appspot.com/77810/diff/34/1016#newcode163 Line 163: if (hasEntered) { This solution is error-prone, but I'm not sure there's a good one. In particular, the event loop *can* get reentered-- in which case, you'd really want to treat the inner stack as its own thing, catch uncaught exceptions, etc. But this code is going to treat it like it's all one stack, when it might not be. I think it'd be better not to bother with worrying about reentrancy here and specialize FinallyCommand.flush() instead. http://gwt-code-reviews.appspot.com/77810 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
