Reviewers: Lex, Description: Hi Lex,
could you review this small patch for me? It cleans up the SOYC options (b/2153332) by: 1) undocumenting -soyc and introducing -compileReport (which is documented), both of which will set soycEnabled to true. 2) causing -XsoycDetailed to turn on soycEnabled too. Thanks! kathrin Please review this at http://gwt-code-reviews.appspot.com/77826 Affected files: dev/core/src/com/google/gwt/dev/Precompile.java dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoyc.java dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycDetailed.java Index: dev/core/src/com/google/gwt/dev/Precompile.java =================================================================== --- dev/core/src/com/google/gwt/dev/Precompile.java (revision 6380) +++ dev/core/src/com/google/gwt/dev/Precompile.java (working copy) @@ -43,6 +43,7 @@ import com.google.gwt.dev.util.Memory; import com.google.gwt.dev.util.PerfLogger; import com.google.gwt.dev.util.Util; +import com.google.gwt.dev.util.arg.ArgHandlerCompileReport; import com.google.gwt.dev.util.arg.ArgHandlerDisableAggressiveOptimization; import com.google.gwt.dev.util.arg.ArgHandlerDisableCastChecking; import com.google.gwt.dev.util.arg.ArgHandlerDisableClassMetadata; @@ -107,6 +108,7 @@ registerHandler(new ArgHandlerMaxPermsPerPrecompile(options)); registerHandler(new ArgHandlerSoyc(options)); registerHandler(new ArgHandlerSoycDetailed(options)); + registerHandler(new ArgHandlerCompileReport(options)); } @Override Index: dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoyc.java =================================================================== --- dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoyc.java (revision 6380) +++ dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoyc.java (working copy) @@ -36,6 +36,11 @@ @Override public String getTag() { return "-soyc"; + } + + @Override + public boolean isUndocumented() { + return true; } @Override @@ -43,4 +48,5 @@ options.setSoycEnabled(true); return true; } + } Index: dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycDetailed.java =================================================================== --- dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycDetailed.java (revision 6380) +++ dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycDetailed.java (working copy) @@ -15,15 +15,16 @@ */ package com.google.gwt.dev.util.arg; +import com.google.gwt.dev.Precompile.PrecompileOptions; import com.google.gwt.util.tools.ArgHandlerFlag; /** * An ArgHandler that enables detailed Story Of Your Compile data collection. */ public class ArgHandlerSoycDetailed extends ArgHandlerFlag { - private final OptionSoycDetailed options; + private final PrecompileOptions options; - public ArgHandlerSoycDetailed(OptionSoycDetailed options) { + public ArgHandlerSoycDetailed(PrecompileOptions options) { this.options = options; } @@ -45,6 +46,7 @@ @Override public boolean setFlag() { options.setSoycExtra(true); + options.setSoycEnabled(true); return true; } } --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
