Thanks for doing this!

One file is missing from the patch.

Also, how about a test in CompilerTest that these options are working as
intended:

1. both -soyc and -compileReport turn on isSoycEnabled
2. the -soycDetailed option also causes isSoycEnabled



http://gwt-code-reviews.appspot.com/77826/diff/1/2
File dev/core/src/com/google/gwt/dev/Precompile.java (right):

http://gwt-code-reviews.appspot.com/77826/diff/1/2#newcode111
Line 111: registerHandler(new ArgHandlerCompileReport(options));
This class is missing from the patch.

http://gwt-code-reviews.appspot.com/77826/diff/1/4
File
dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSoycDetailed.java
(right):

http://gwt-code-reviews.appspot.com/77826/diff/1/4#newcode49
Line 49: options.setSoycEnabled(true);
Excellent.  That repairs a loose end.

http://gwt-code-reviews.appspot.com/77826

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to