Hi John,

Can you please review this?  Start with a clean, updated trunk and do:

svn cp https://google-web-toolkit.googlecode.com/svn/trunk/j...@6365 jni

svn cp
https://google-web-toolkit.googlecode.com/svn/trunk/dev/windows/src/com/google/gwt/dev/shell/i...@6365dev/core/src/com/google/gwt/dev/shell/ie

svn rm dev/core/src/com/google/gwt/dev/shell/LowLevel.java
dev/core/src/com/google/gwt/dev/shell/ie/MethodDispatch.java
dev/core/src/com/google/gwt/dev/shell/ie/ModuleSpaceIE6.java
dev/core/src/com/google/gwt/dev/shell/ie/COMObjectProxy.java
dev/core/src/com/google/gwt/dev/shell/ie/IDispatchImpl.java
dev/core/src/com/google/gwt/dev/shell/ie/IDispatchProxy.java
dev/core/src/com/google/gwt/dev/shell/ie/SwtOleGlue.java
dev/core/src/com/google/gwt/dev/shell/ie/BrowserWidgetIE6.java
dev/core/src/com/google/gwt/dev/shell/ie/JsValueIE6.java

patch -p0 < checkforupdates.patch


Your client status should look like this:

$ svn statusA  +    jni
M  +    jni/build.xml
M       build.xml
M       distro-source/build.xml
D       dev/core/src/com/google/gwt/dev/shell/LowLevel.java
M       dev/core/src/com/google/gwt/dev/shell/CheckForUpdates.java
A  +    dev/core/src/com/google/gwt/dev/shell/ie
D       dev/core/src/com/google/gwt/dev/shell/ie/MethodDispatch.java
D       dev/core/src/com/google/gwt/dev/shell/ie/ModuleSpaceIE6.java
D       dev/core/src/com/google/gwt/dev/shell/ie/COMObjectProxy.java
D       dev/core/src/com/google/gwt/dev/shell/ie/IDispatchImpl.java
D       dev/core/src/com/google/gwt/dev/shell/ie/IDispatchProxy.java
D       dev/core/src/com/google/gwt/dev/shell/ie/SwtOleGlue.java
D       dev/core/src/com/google/gwt/dev/shell/ie/BrowserWidgetIE6.java
M  +    dev/core/src/com/google/gwt/dev/shell/ie/LowLevelIE6.java
D       dev/core/src/com/google/gwt/dev/shell/ie/JsValueIE6.java
M  +    dev/core/src/com/google/gwt/dev/shell/ie/CheckForUpdatesIE6.java


Stuff that might not be self-explanatory:

- LowLevel is now completely unused, I moved the code that used to load
gwt-ll into LowLevelIE6.

- The 1-arg ctor for CheckForUpdates was never used anywhere.

- Had to modify jni/build.xml because platforms.ant.xml is basically useless
now (and should probably get removed at some point).

- I have NOT gone in and messed with the gwt-ll at all.. the existing binary
works fine.  I can go back and remove the other platforms, stuff that isn't
needed, etc, but it didn't seem critical to change right now.

Thanks!
Scott

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Attachment: checkforupdates.patch
Description: Binary data

Reply via email to