On Thu, Oct 15, 2009 at 2:37 PM, Scott Blum <[email protected]> wrote:

> Stuff that might not be self-explanatory:
>
> - LowLevel is now completely unused, I moved the code that used to load
> gwt-ll into LowLevelIE6.
>
> - The 1-arg ctor for CheckForUpdates was never used anywhere.
>
> - Had to modify jni/build.xml because platforms.ant.xml is basically
> useless now (and should probably get removed at some point).
>
> - I have NOT gone in and messed with the gwt-ll at all.. the existing
> binary works fine.  I can go back and remove the other platforms, stuff that
> isn't needed, etc, but it didn't seem critical to change right now.
>

LGTM with caveats:

   - I am assuming you have tested it actually building a distro and
   verifying that the proxies are respected.
   - Have you tested running from a distro and running from Eclipse
   projects?  I assume it won't work running from the Eclipse projects if
   gwt.devjar isn't set, but that is ok -- I just want to make sure it doesn't
   fail to operate
   - Please create a bug to clean up the jni directory.

-- 
John A. Tamplin
Software Engineer (GWT), Google

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to