Some error message and method name nits, and one weird thing in TabLayoutPanel by accident?
http://gwt-code-reviews.appspot.com/81802/diff/1/2 File user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java (right): http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode46 Line 46: .findType(TabLayoutPanel.class.getName()), Double.toString(size), Any locale gotchas lurking in Double#toString? http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode47 Line 47: DockLayoutPanelParser.getFullyQualifiedEnumName(unit)); You sleazebag. :-) LGTM http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode53 Line 53: writer.die("In %s, only <tab> children are allowed.", panelElem); "...only <%s:%s> children...", panelElem, panelElem.getPrefix(), TAB) http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode88 Line 88: writer.die("%s requires either a <%s> or <%s>", tabElem, HEADER, CUSTOM); writer.die("%1$s requires either a <%2$s:%3$s> or <%2$s:%4$s>", tabElem, tabElem.getPrefix(), HEADER, CUSTOM) http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode129 Line 129: private boolean hasAttribute(XMLElement child, final String attribute) { Should be called hasTag, right? Probably my bad. http://gwt-code-reviews.appspot.com/81802/diff/1/4 File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/81802/diff/1/4#newcode135 Line 135: tabBar.getElement().getStyle().setWidth(16384, Unit.PX); Is this on purpose? http://gwt-code-reviews.appspot.com/81802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
