Thanks. All should be addressed in the next patch.
http://gwt-code-reviews.appspot.com/81802/diff/1/2 File user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java (right): http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode46 Line 46: .findType(TabLayoutPanel.class.getName()), Double.toString(size), On 2009/10/16 19:25:29, Ray Ryan wrote: > Any locale gotchas lurking in Double#toString? I assume not, since there's no Locale override. http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode47 Line 47: DockLayoutPanelParser.getFullyQualifiedEnumName(unit)); On 2009/10/16 19:25:29, Ray Ryan wrote: > You sleazebag. :-) LGTM Guilty as charged. My assumption is that this will be moved into XmlElement once we get the enum parser added. http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode53 Line 53: writer.die("In %s, only <tab> children are allowed.", panelElem); On 2009/10/16 19:25:29, Ray Ryan wrote: > "...only <%s:%s> children...", panelElem, panelElem.getPrefix(), TAB) Done. http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode129 Line 129: private boolean hasAttribute(XMLElement child, final String attribute) { On 2009/10/16 19:25:29, Ray Ryan wrote: > Should be called hasTag, right? Probably my bad. Done. http://gwt-code-reviews.appspot.com/81802/diff/1/4 File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/81802/diff/1/4#newcode135 Line 135: tabBar.getElement().getStyle().setWidth(16384, Unit.PX); On 2009/10/16 19:25:29, Ray Ryan wrote: > Is this on purpose? Sorry, not clear. Will add comment. This is necessary to keep the tabbar's children from wrapping. http://gwt-code-reviews.appspot.com/81802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
