Thanks for the review of the arghandler code. Updated the patch set with the suggested changes.
http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.setRemoteUIArgs(remoteUIArgs); On 2009/10/20 21:22:52, jat wrote: > On 2009/10/20 21:21:06, mmendez wrote: > > This seemed more congruent with the pattern that exists in this code. > The existing code is the fallback, if no option specified a different UI > implementation. Good suggestion; done. During the init of the RemoteUI in the arghandler, a RuntimeException can be thrown (during the connection phase). Is it appropriate to throw such an exception at this point in the code? http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode964 Line 964: ui = new RemoteUI(options.getRemoteUIArgs().host, On 2009/10/20 21:13:09, jat wrote: > Shouldn't this just be created in the arg handler? Done. http://gwt-code-reviews.appspot.com/83802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
