http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right):
http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.setRemoteUIArgs(remoteUIArgs); On 2009/10/20 21:57:53, rdayal wrote: > On 2009/10/20 21:22:52, jat wrote: > > On 2009/10/20 21:21:06, mmendez wrote: > > > This seemed more congruent with the pattern that exists in this code. > > > > The existing code is the fallback, if no option specified a different UI > > implementation. > Good suggestion; done. During the init of the RemoteUI in the arghandler, a > RuntimeException can be thrown (during the connection phase). Is it appropriate > to throw such an exception at this point in the code? I would think you want to catch it, print an appropriate error (the logger isn't available yet), and then return false from the arg handler. An exception won't be the end of the world, but it is inconsistent with other arg handlers. http://gwt-code-reviews.appspot.com/83802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
