Revision: 6581
Author: [email protected]
Date: Mon Nov 2 09:21:49 2009
Log: De-deprecate HandlerManager.removeHandler, resolves issue 3102
Review by jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6581
Modified:
/trunk/user/src/com/google/gwt/event/shared/HandlerManager.java
/trunk/user/test/com/google/gwt/event/shared/HandlerManagerTest.java
=======================================
--- /trunk/user/src/com/google/gwt/event/shared/HandlerManager.java Wed Oct
28 09:10:53 2009
+++ /trunk/user/src/com/google/gwt/event/shared/HandlerManager.java Mon
Nov 2 09:21:49 2009
@@ -236,12 +236,7 @@
*
* @param type the event type
* @param handler the handler
- * @deprecated This method is likely to be removed along with "listener"
- * interfaces in a future release. If you have a reason it
should
- * be retained beyond that time, please add your comments to
GWT
- * <a
href="http://code.google.com/p/google-web-toolkit/issues/detail?id=3102";>issue
3102</a>
*/
- @Deprecated
public <H extends EventHandler> void removeHandler(GwtEvent.Type<H> type,
final H handler) {
if (firingDepth > 0) {
=======================================
--- /trunk/user/test/com/google/gwt/event/shared/HandlerManagerTest.java
Wed Oct 28 09:10:53 2009
+++ /trunk/user/test/com/google/gwt/event/shared/HandlerManagerTest.java
Mon Nov 2 09:21:49 2009
@@ -64,7 +64,6 @@
assertNotFired(click1, click2);
}
- @SuppressWarnings("deprecation")
public void testRemoveHandlers() {
HandlerManager manager = new HandlerManager("bogus source");
addHandlers(manager);
@@ -189,7 +188,6 @@
assertNotFired(two);
}
- @SuppressWarnings("deprecation")
public void testConcurrentAddAfterRemoveIsNotClobbered() {
final HandlerManager manager = new HandlerManager("bogus source");
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
